Debugging graphic tests in roottest #1153
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks! Could you please add a corresponding PR in ROOT in order to have the CI picking up these tests? |
dpiparo
reviewed
Jul 26, 2024
| } else { | ||
| std::cerr << "Error: Unable to open file for writing" << std::endl; | ||
| return 1; | ||
| // Save the generated JSON file |
Member
There was a problem hiding this comment.
Please remove this part:it would simply write confusing output disguised as references.
dpiparo
requested changes
Jul 26, 2024
Member
dpiparo
left a comment
dpiparo
left a comment
There was a problem hiding this comment.
Please remove the part where output jsons are written out as references. In other words, do not change the file graphics/testGraphics.C
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The json reference files have been changed on top of the changes proposed in this PR #1152 . The objective is to reduce to the minimum the currently ubiquitous failures occurring when testing json files.